freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Updates to Docwriter: Logging, testing, linting


From: Werner LEMBERG
Subject: Re: [ft-devel] Updates to Docwriter: Logging, testing, linting
Date: Sun, 15 Jul 2018 21:08:39 +0200 (CEST)

> See the attached images. 'indent_4' is the current formatting, and
> 'indent_2' is formatting done using 'yapf' with chromium style (2
> spaces) and column limit 78.

Thanks.  I still prefer 2-space indentation; for deeper nesting levels
it is easier to stay within the 78 (or 79) character-per-line limit...

> The auto formatters (both yapf and black), however, perform somewhat
> undesirable changes at places. See 'regex_indent_old' and
> 'regex_indent_new' as an example.

Ouch.  Looks like bugs in the formatters...

>> In PEP 8, value 4 for indentation is like the parallel postulate:
>> it is completely isolated from all other recommendations...
> 
> I'm not sure what you mean by 'isolated' here, [...]

I mean: If you change this value, it doesn't have any consequence to
the remaining rules (the same is true for Euclid's parallel
postulate).

> I'll wait before applying a formatter till there is a consensus
> hereĀ :-)

Indeed.  You shouldn't waste time on this issue since you already
maintain well-formatted code.


    Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]