Re: [Gnash-commit] gnash/libgeometry Range2d.h

[strk]

On Thu, Mar 01, 2007 at 10:17:41PM +0000, Martin Guy wrote:
> >Please, *before* making any change, get 'make check' to work.
> >Last change you made is still unresolved in that reguard (make check fails)
> 
> Ye, you've said that twice now, but I haven't got to the bottom of it.
> make check does not even compile/run for me, failing itself in the
> ways I described to you.
> I run Date.as with makeswf and gnash, and all the tests give the
> expected results. That has been useful, but so far I am unable to

makeswf -v5 gives you an SWF5 output. Of course the other problem
is reading traces visually, and make Date-v5.swf should take care of that.
If you give me an account on your host I can check what's wrong with Ming 
there...
 
> If you need a fast solution, I suggest removing or commenting out all
> the test cases I put in for correct Date functionality, reducing it
> once again to just checking for the existence of the methods, since it
> appears to be tickling bugs in "make check". The code works fine

My problem is not Gnash failing , we can use xcheck/xcheck_equals for that.
Rather, I don't think the tests are correct.

> except for Date.UTC() not appearing as a runtime method as it should -
> which depends on figuring out the AS method interface, which is why I
> am trying to figure that out. It is the blocking point in my current
> work.

I noted you're naming an instance 'date', but SWF up to 6 is case-insensitive,
so the instance will hide the class.

check_equals(typeOf(Date.UTC), 'function');
var date = new Date(70,1,2,3,4,5,6);
check_equals(typeOf(Date.UTC), 'undefined');

> Mind you, if the current "make check/dejagnu/expect/ming" stuff is so
> badly broken as to impede progress in this way, it might be worth
> ditching in favour of something simpler that works reliably, or maybe
> stop taking what it says seriously.

If you run gprocessor -v dejagnu gets out of your way and you can see
wheter things are working or not. I'm not blindly trusting dejagnu here :)

--strk;