gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog libamf/element.cpp libnet/cque....


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog libamf/element.cpp libnet/cque....
Date: Mon, 7 Apr 2008 21:41:52 +0200

On Mon, Apr 07, 2008 at 07:35:11PM +0000, Rob Savoye wrote:

>               * libnet/cque.cpp: Only delete the pointer if we actually have
>               data. Handle merging differently to eliminate problem with
>               singular interators. Not this fixes the abort, but leaks memory 
> as
>               the original buffers aren't removed from the que like they need 
> to
>               be. This at least get make check working for libnet.all.

Rob, I provided a clean patch for ::merge.
It wasn't deleting elements as I wasn't sure about ownership, but would be
pretty easy to modify to remove the merged lines.

If we have test for merging it should be easy to verify it's functionality.

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]