gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog libamf/element.cpp libnet/cque....


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog libamf/element.cpp libnet/cque....
Date: Mon, 7 Apr 2008 22:37:24 +0200

On Mon, Apr 07, 2008 at 02:27:54PM -0600, Rob Savoye wrote:

> RTMP knows how many bytes it wants, so
> it only merges buffers when it knows it is missing data.

Maybe we can add another argument to contain the max size we want the
merged buffer to have ?

> Anytime a buffer of data is copied, there is a performance hit,
> so you want to do it as seldom as possible.

The important thing is to define ownership of those buffers, which
is finding out which class is responsible to get rid of them.
Smart pointers may help for both shared ownership and ownership
transfer.

> >     Before merge:
> >     A1 A2 A3 B1 B2 B3 B4 C1 C2 
> > 
> >     After merge starting at B:
> >     A1 A2 A3 A4 B C1 C2
> 
>   Correct, the order shouldn't change.

Ok, committed a fix for this too.

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]