[Gnash-commit] [patch #7533] [PATCH] AbcBlock.h: checkBounds should check for negative values

[Sandro Santilli]

Follow-up Comment #3, patch #7533 (project gnash):

The point is that if size_t can't be negative there's no point in checking for
it to be < 0.
The compiler should notice that and warn you with something like: "comparison
will always be false". Please check if it does.

If a caller tries to pass a negative number to a function expecting an
unsigned type the body of the funcion will see that value reinterpreted as a
positive value, which usually gets evaluated as > [maxvalue].

If a check has to be made for negative values it should be made outside of the
function, that is while the value is still signed, right after reading it from
the stack...

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7533>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/