Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2223-gac2b26f

[Richard Wilbur]

On Wed, Dec 2, 2015 at 7:37 AM, Sandro Santilli <address@hidden> wrote:
[...]
> diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh 
> b/testsuite/misc-mtasc.all/extcommtests-runner.sh
> new file mode 100644
> index 0000000..10aa3ef
> --- /dev/null
> +++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
[...]
> +cat << EOF
> +
> +# Filenames and constants
> +LOGFILE=${top_builddir}/testoutlog.\$$
> +PIPE2CONTAINER=${top_builddir}/tocontainer.\$$
> +PIPE2PLAYER=${top_builddir}/toplayer.\$$

I'm curious why only the first '$' is escaped in each of these ('\$$'), ...

[...]
> +# read_timeout(\$varname, \$timeout)
> +# Read one line from standard input, with a specified timeout (in seconds)
> +read_timeout() {
> +       trap 'trap - USR1; return 142' USR1
> +       (sleep "\$2" && kill -USR1 "\$\$" > /dev/null 2>&1) &
> +       TIMEOUTPID=\$!
> +       read "\$1"
> +       READERROR=\$?
> +       kill "\$TIMEOUTPID" > /dev/null 2>&1
> +       trap - USR1
> +       return \$READERROR
> +}

as opposed to the double "\$\$" in read_timeout() (where both are escaped)?


[...]
> +# Open host-to-player pipe
> +exec 4<> "\$PIPE2PLAYER"
> +check_error \$? "Failed to open a named pipe: \$PIPE2CONTAINER"

Didn't you mean to say:
+check_error \$? "Failed to open a named pipe: \$PIPE2PLAYER"

Sincerely,
Richard