gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi


From: Sandro Santilli
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2223-gac2b26f
Date: Fri, 4 Dec 2015 16:48:54 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Dec 03, 2015 at 04:19:44PM -0700, Richard Wilbur wrote:
> On Wed, Dec 2, 2015 at 7:37 AM, Sandro Santilli <address@hidden> wrote:

> > +PIPE2PLAYER=${top_builddir}/toplayer.\$$
> 
> I'm curious why only the first '$' is escaped in each of these ('\$$'), ...

A single dollar sign doesn't seem to be interpreted as a variable.

> > +       (sleep "\$2" && kill -USR1 "\$\$" > /dev/null 2>&1) &
> 
> as opposed to the double "\$\$" in read_timeout() (where both are escaped)?

I think Nutchanon just copied this from the XMLSocketTester,
anyway he's in Cc now :)

> > +# Open host-to-player pipe
> > +exec 4<> "\$PIPE2PLAYER"
> > +check_error \$? "Failed to open a named pipe: \$PIPE2CONTAINER"
> 
> Didn't you mean to say:
> +check_error \$? "Failed to open a named pipe: \$PIPE2PLAYER"

Thanks for checking, fixed with commit
eda27746fcd190fc4092e0cb1166726bebf000df

--strk;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]