[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Alignment in AMF data

From: Rob Savoye
Subject: Re: [Gnash-dev] Alignment in AMF data
Date: Fri, 24 Oct 2008 11:08:09 -0600
User-agent: Thunderbird (X11/20080723)

Russ Nelson wrote:

> Unfortunately, fetching full-sized data from a buffer is subject to
> alignment problems.  Rob (our fearless leader) doesn't like the
> following code, but it never has byte sex or alignment problems, and
> there's never any ambiguity about exactly what you're loading.

  I never said I didn't like this code, what I said is we should avoid
code duplication, and use existing functions for swapping bytes. Gnash
uses both swapBytes() and the ntohl(), etc.. macros for byte swapping,
which is what we should be using.

        - rob -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]