gnats/111: Access levels smaller than viewconf cannot query PRs at all

[opel]

>Number:         111
>Category:       gnats
>Synopsis:       Access levels smaller than viewconf cannot query PRs at all
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 17 19:14:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Steffen Opel
>Release:        gnats-4.0-alpha
>Organization:
>Environment:
Linux gg.geekgadgets.org 2.2.16-22 #1 Tue Aug 22 16:49:06 EDT 2000 i686 unknown
>Description:
Users with access level smaller than viewconf cannot query PRs at all due to a 
bug in cmds.c (set_confidential_access):
The supplied query expression errorneously uses 'builtin:Confidential' instead 
of 'builtinfield:Confidential', see fix below.
>How-To-Repeat:
Login as a user with just 'view' access level into a database with 
non-confidential PRs and do for example:
QFMT full
QUER

No PRs will be returned!
>Fix:
Index: cmds.c
===================================================================
RCS file: /cvs/gnats/gnats/gnats/cmds.c,v
retrieving revision 1.49
diff -c -r1.49 cmds.c
*** cmds.c      2000/08/15 00:12:39     1.49
--- cmds.c      2000/10/18 01:57:14
***************
*** 363,369 ****
    if (user_access < ACCESS_VIEWCONF)
      {
        QueryExpr newQ = parseQueryExpression (currentDatabase, 
!                                            "builtin:Confidential ~ \"no\"",
                                             NULL);
        *search = booleanQuery (QueryAnd, *search, newQ);
      }
--- 363,369 ----
    if (user_access < ACCESS_VIEWCONF)
      {
        QueryExpr newQ = parseQueryExpression (currentDatabase, 
!                                            "builtinfield:Confidential ~ 
\"no\"",
                                             NULL);
        *search = booleanQuery (QueryAnd, *search, newQ);
      }
Index: ChangeLog
===================================================================
RCS file: /cvs/gnats/gnats/gnats/ChangeLog,v
retrieving revision 1.159
diff -c -r1.159 ChangeLog
*** ChangeLog   2000/08/23 19:55:22     1.159
--- ChangeLog   2000/10/18 01:57:14
***************
*** 1,3 ****
--- 1,7 ----
+ 2000-10-17  Steffen Opel  <address@hidden>
+ 
+       * cmds.c (set_confidential_access): Fixed query expression.
+ 
  Wed Aug 23 12:49:59 2000  Bob Manson  <address@hidden>
  
        * pr.c (verifyMultiEnum): Accept NULL values if the field doesn't
>Release-Note:
>Audit-Trail:
>Unformatted: