Re: [Gnu-arch-users] tla1.2 on cygwin

[lode . leroy]

>Seconded.  I'm less familiar with your approach than Rob is though
>what I've seen sounds plausible and his confirmation is significant.
>
>I wonder now if it needs to be a fork.  Is some of the cygwin support
>of more general utility?   Perhaps it is worth folding into the
>mainline (slowly).
>
>-t

Tom,

Could you have a look at the sources that I contributed?

The changes are absolutely minimal:

I do a vu_push_handler in tla.c and modify getcwd() into
pathcompress_getcwd(). That's all.
Actually 2 lines of code are changed in the tla 1.2 sources,
this is in the patch "tla-pathcompress-src".

The patch "tla-exec-suffix" fixes a compile problem on cygwin,

"rm ,es" is changed to rm ,es${cfg__exec__suffix}
in the makefiles. please apply this patch to mainline,
sine it does not impact the other builds.

the patch "tla-pathcompress-build" changes the makefiles
to add vu-pathcompress.o to the link statement for tla.
There should be a better way to do this, but I'm not
so familiar with automake.

Could you have a look to integrate this in the mainline of tla,
maybe with
"#ifdef __CYGWIN32__"
or maybe better with a compile-time option
"#ifdef cfg__pathcompress" and "./configure --with-pathcompress"
?

The other piece of code I would like reviewed is the first
function of "pathcompress.c" which is called "is_compressed()"
It decides wether a (full) path needs to be compressed.
The idea is to compress all potentially long paths,
but not the user-created directories.

It's also possible to compile the on linux with these patches,
so if you want to test it, you don't actually have to run it on windows.

-- lode



----------------------------------------------------------------------------------
Plaats je zoekertjes GRATIS op AdValvas
Placez votre petite annonce GRATUITEMENT sur AdValvas
http://www.advalvas.be

pathcompress-0.14.tar.gz
Description: GNU Zip compressed data

tla-exec-suffix.diff
Description: Binary data

tla-pathcompress-build.diff
Description: Binary data

tla-pathcompress-src.diff
Description: Binary data

BUILD.txt
Description: Text document