Re: [gnugo-devel] GNU Go 3.7.13

[Daniel Bump]

Wietze Brandsma proposed some changes that fix some
compiler warnings on Windows.

Here is a patch which I believe implements what you
described in your email.

http://lists.gnu.org/archive/html/gnugo-devel/2008-12/msg00065.html

Could you confirm that these are the changes you are
proposing?

Thanks for looking into this.

Dan

Index: engine/owl.c
===================================================================
RCS file: /var/lib/cvs/gnugo_3_8/engine/owl.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 owl.c
--- engine/owl.c        17 Dec 2008 14:28:08 -0000      1.1.1.1
+++ engine/owl.c        26 Dec 2008 22:48:03 -0000
@@ -5148,7 +5148,7 @@
       for (k = 0; k < num_cuts; k++)
        if (component[k] == c_id) {
          mark_string(cuts[k], this_goal, 1);
-         mark_string(cuts[k], component2, c_id);
+         mark_string(cuts[k], component2, (signed char) c_id);
        }
       init_connection_data(color, this_goal, NO_MOVE, FP(3.01),
                           conn_data + c_id, 1);
@@ -5173,7 +5173,7 @@
       }
       /* FIXME: What to do if no close component found? */
       if (closest_component != -1) {
-       mark_string(pos, component2, closest_component);
+       mark_string(pos, component2, (signed char) closest_component);
        component_size[closest_component] += countstones(pos);
       }
     }
Index: interface/main.c
===================================================================
RCS file: /var/lib/cvs/gnugo_3_8/interface/main.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 main.c
--- interface/main.c    17 Dec 2008 14:28:08 -0000      1.1.1.1
+++ interface/main.c    26 Dec 2008 22:45:28 -0000
@@ -1792,7 +1792,7 @@
   }
 
   address.sin_family = AF_INET;
-  address.sin_port = htons(port);
+  address.sin_port = htons((unsigned short) port);
 
   for (address_pointer = host_data->h_addr_list; *address_pointer;
        address_pointer++) {
@@ -1859,7 +1859,7 @@
   }
 
   address.sin_family = AF_INET;
-  address.sin_port = htons(port);
+  address.sin_port = htons((unsigned short) port);
 
   if (verbose) {
     if (host_name) {
Index: patterns/mkmcpat.c
===================================================================
RCS file: /var/lib/cvs/gnugo_3_8/patterns/mkmcpat.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 mkmcpat.c
--- patterns/mkmcpat.c  17 Dec 2008 14:28:08 -0000      1.1.1.1
+++ patterns/mkmcpat.c  26 Dec 2008 22:47:09 -0000
@@ -127,7 +127,7 @@
     printf("static const unsigned int %s_values[] = {\n", name);
     for (k = 0; k < N; k++) {
       printf("%u, ", values[k]);
-      if (k % 8 == 7)
+      if (k % 8 == 15)
        printf("\n");
     }
     printf("\n};\n\n");