[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: NSBrowser cleanup

From: Alexander Malmberg
Subject: Re: NSBrowser cleanup
Date: Wed, 30 Jun 2004 22:05:00 +0200

Serg Stoyan wrote:
> Hi everybody,
> Doing some fixes in NSBrowser I come up to idea that NSBrowser needs some
> reorganization. Let me explain what I mean.
> NSBrowser.m has 3 classes NSBrowserColumn,  GSBrowserTitleCell and NSBrowser 
> itself.
> The idea is to sepearate classes location:
> - NSBrowser stays in NSBroser.m
> - NSBrowserColumn goes into AppKit/NSBrowserColumn.h  and 
> Sources/NSBrowserColumn.m
> - change GSBrowserTitleCell name to NSBrowserTitleCell and put into
>   AppKit/NSBrowserTitleCell.h and Sources/NSBrowserTitleCell.m

As Gregory pointed out, that should be GSBrowserTitleCell and
GSBrowserColumn, and since they're GNUstep classes, the headers should
go in GNUstepGUI/, not AppKit/.

> Notice that NSBrowserTitleCell.h and NSBrowserColumn.h can be installable or 
> not.

If you know that they aren't going to be installed, they should be
placed in Source/. If you're unsure, I guess GNUstepGUI/ makes sense,
but it'd be better to get it right the first time; cvs isn't happy about
moving files around.

> I've done some formatting inside NSBrowser.m also. The basic principles of 
> this
> formatting are:
[snip principles]
> Moreover, when documentation generated, we'll see GNUstep and Cocoa
> specific methods (if any) separated from OpenStep standard's methods.

It seems to me that this should be handled by markers in the
documentation comments (in fact, I thought we already had something like
that), and the separation should be optional when the documentation is
generated. (I don't think GNUstep users have any interest in the
separation; I know I don't.)

> What do everybody think about adding such formatting rules info "Coding 
> Style" section of
> "Coding Standarts" document?

No. I can't see anything good coming out of trying to be rigid about
this, and if we're going to do it, I disagree with your principles (and
Richard's, fwiw :).

I'd also be very wary of reorganizing existing code, but if you're going
to do _extensive_ work on NSBrowser, I guess I don't mind if you
reorganize it the way you like it at the same time.

- Alexander Malmberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]