Thank you for this contribution.
You will mostly handle copyright assignment with FSF. I originally emailed
address@hidden and they gave me the following form. You will need to snailmail them some documentation; when you do so, please email Gregory and me a scan so we speed up the process.
----8<-------
Please email the following information to address@hidden, and wewill send you the assignment form for your past and future changes.Please use your full name as the subject line of the message.[What is the name of the program or package(s) you're contributing to?][Did you copy any files or text written by someone else in these changes?Even if that material is free software, we need to know about it.][Do you have an employer who might have a basis to claim to ownyour changes? Do you attend a school which might make such a claim?][For the copyright registration, what country are you a citizen of?][What year were you born?][Please write your email address here.][Please write your snail address here.][Which files have you changed so far, and which new files have you writtenso far?] ----8<-------
As far as I can tell, sysAppDir is actually an ugly hack used to figure out path to the 'System' folder. Essentially, it's used in assigning icon not to '/System/Applications' but to '...../System/Applications/..', by checking that '..' is named 'System'. There has to be a better way to assign the GSFolder icon to it.
As far as your patch goes, LGTM. Thank you for your contribution.
As far as the new image goes, it strongly reminds me of common_GSFolder.tiff used for the system folder -- in general it looks more like a 'GNUstep system' icon than application icon. However -- I can see it's derived from common_UnknownApplication.tiff, so I'm okay with it. Thank you.