Re: Missing curly braces in rsa_params::operator= (gnutlsxx.cpp)?

[Simon Josefsson]

Jason Pettiss <address@hidden> writes:

> I have version 2.8.4 of the source... tried to check the latest in the CVS 
> repository but the CVS server itself seems to be out of disk space?

We haven't used CVS in quite a while, please check instructions on how
to retrieve sources from Git:

https://savannah.gnu.org/git/?group=gnutls

Btw, did you read that we used CVS somewhere?  I may have forgotten to
update some old information.

> Anyway it looks like the error check in rsa_params::operator= is missing a 
> code block and will unconditionally throw.
>
> rsa_params & rsa_params::operator=(const rsa_params& src)
> {
>     rsa_params* dst = new rsa_params;
>     int ret;
>     ret = gnutls_rsa_params_cpy( dst->params, src.params);
>     if (ret < 0)
>         delete dst;
>     throw(ret);
>     return *dst;
> }
>
> Probably should have been:
>
>     if (ret < 0) {
>         delete dst;
>         throw(ret);

Heh.  Fixed, thank you.

/Simon