[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Split of raid scan code

From: Robert Millan
Subject: Re: [PATCH] Split of raid scan code
Date: Tue, 12 Aug 2008 15:32:23 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Aug 12, 2008 at 07:49:19PM +0800, Bean wrote:
> Ok, I make some adjustment, now grub-install & update-grub works for
> raid device.
> [...]
> --- a/util/grub-probe.c
> +++ b/util/grub-probe.c
> @@ -142,7 +142,7 @@ probe (const char *path, char *device_name)
>         abstraction_name = "lvm";
>         break;
> -       abstraction_name = "raid";
> +       abstraction_name = "raid mdraid";

Should be fine, I think.

> -         buf += read_size;
> +         buf += read_size << GRUB_DISK_SECTOR_BITS;

Felix told me this fixes a problem in current RAID code;  when you check
your code in, please consider including this bugfix in a separate commit.
This makes it easier to track things.


Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]