[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

From: Marco Gerards
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
Date: Thu, 14 Aug 2008 09:13:40 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Felix Zielcke <address@hidden> writes:

> Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke:
>> This time dear Marco I didn't bother to read through the changelog, it
>> might be still not perfect and I'm even tired now.
> I should have better gone to bed instead of making quickly a patch for
> this.
> Well 2nd try now.
> I forgot grub-fstest and I think I know now why you said `why' to one
> entry ;)
> And I forgot to change the copyright year to 2008 for the new shiny
> util/err.c

So this patch isn't really required, but you want it for Lenny?

> 2008-08-14  Felix Zielcke  <address@hidden>
>         * include/grub/err.h (grub_error_stack_assert): New variable
>         declaration.
>         * kern/err.c (grub_error_stack_assert): Remove static.
>         (grub_print_error): Disable it for [GRUB_UTIL] because ...
>         * util/err.c: New file with grub_print_error () using fprintf 
>         (stderr, ...).

Can you just use misc.c?

>         * conf/common.rmk: Add it for grub-probe.

I have been thinking of an alternative way to fix this.  A bit of a
compromise between what you want and what I want and perhaps cleaner.

You could define a function grub_err_printf or something like that.
Which you use in grub_print_error.  You can redefine it for
GRUB_UTIL to grub_util_error and to grub_print otherwise.

I didn't study the code.  Will this be easier and cleaner?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]