[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: status grub2 port of grub-legasy map command
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: status grub2 port of grub-legasy map command |
Date: |
Mon, 1 Jun 2009 23:45:11 +0200 |
2009/6/1 Javier Martín <address@hidden>:
> El lun, 01-06-2009 a las 11:53 +0200, Vladimir 'phcoder' Serbinenko
> escribió:
>> > Hmm... from those docs, and accepting that we ignore TSRs, we need to
>> > save %ah and %dl at handler entry, then check the saved %ah at exit,
>> > like the old handler from GRUB Legacy did - by the way, when writing the
>> > new handler, I asked what that code did and noone was able to tell me ¬¬
>> I've the check before calling original handler. Let's hope it makes
>> code more readable.
> Personally, I don't think the readability gain is so big to offset the
> code size increase, but this is just a single opinion.
I personally don't really care how to do it. But for economy of effort
I prefer to take what I already have :) But if you insist I can change
it
> I think the other
> part of the patch should be committed right now, though.
This might be a problem ;) (we still have no repository online:( )
>
> --
> -- Lazy, Oblivious, Recurrent Disaster -- Habbit
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'phcoder' Serbinenko