[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATH] grub-mkrelpath

From: Robert Millan
Subject: Re: [PATH] grub-mkrelpath
Date: Fri, 28 Aug 2009 18:28:28 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Aug 28, 2009 at 02:53:12PM +0200, Felix Zielcke wrote:
> +      if (stat (buf, &st) < 0)
> +     grub_util_error ("can not stat %s", buf);

We should give a reason.  E.g:

  grub_util_error ("can not stat %s: %s", p, strerror (errno));

Also, I believe some of the comments in the old shell function
(e.g. the one about trailing slash) would still make sense in the
new one.

If you can fix these two things, it looks ok for commit.  Thanks.

Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]