[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enhanced hotkey handling for menuentry

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] Enhanced hotkey handling for menuentry
Date: Sat, 03 Mar 2012 22:01:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0

On 03.03.2012 21:43, Andreas Vogel wrote:
Here is a small patch which enhances the hotkey handling for menu entries.
Could you use GNU style? You miss the spaces before braces. Comments have to be full sentences, start with uppercase and end with a dot followed by 2 spaces.
Comment /*NOTHING*/ is not useful.
         - new static function parse_key()
         - hotkey aliases are now case insensitive
         - additional hotkey aliases
All added aliases conflict with normal function of these keys (arrows and pages)
         - handling now<SHIFT>  and<CTRL>  modifiers for hotkeys
Could you change to the emacs notation? Shift flag isn't valid with alphanumeric keys.

Vladimir 'φ-coder/phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]