[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enhanced hotkey handling for menuentry

From: Andreas Vogel
Subject: Re: [PATCH] Enhanced hotkey handling for menuentry
Date: Sat, 03 Mar 2012 22:30:43 +0100
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

> On 03.03.2012 21:43, Andreas Vogel wrote:
>> Here is a small patch which enhances the hotkey handling for menu
>> entries.
> Could you use GNU style? You miss the spaces before braces.
Sure. Missed by accident.

> Comments have to be full sentences, start with uppercase and end with
> a dot followed by 2 spaces.
Wow... ok.

> Comment /*NOTHING*/ is not useful.
I disagree, because it's more clear that this is an intentionally left
empty body. But it's a matter of taste and I obey.

>>          - new static function parse_key()
>>          - hotkey aliases are now case insensitive
>>          - additional hotkey aliases
> All added aliases conflict with normal function of these keys (arrows
> and pages)
Yes, I know. But it doesn't harm anyway and it might be useful to have
the code already in case the use of the keys change in the future.
Anyway, if you insist of leaving them out i'll obey.

>>          - handling now<SHIFT>  and<CTRL>  modifiers for hotkeys
> Could you change to the emacs notation?
What is the emacs notation? I have no idea.

> Shift flag isn't valid with alphanumeric keys.
Ah, ok. Am I right that it's enough just not to set the SHIFT mask in
case isalnum() is true?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]