[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] gnu: Add python-avro.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/4] gnu: Add python-avro. |
Date: |
Tue, 04 Oct 2016 11:32:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi!
Marius Bakke <address@hidden> skribis:
> * gnu/packages/serialization.scm (avro-version): New variable (private).
> (avro-source): New variable (private).
> (python-avro, python2-avro): New variables.
[...]
> +;;; Avro uses a single source repository for all implementations. The
> individual
> +;;; released versions often have missing or incomplete test data, so we
> define
> +;;; the common source here for use in all avro packages.
Two semicolons please. :-)
> +(define-public python2-avro
> + (let ((base (package-with-python2 (strip-python2-variant python-avro))))
> + (package (inherit base)
> + (arguments
> + `(#:tests? #f ; Requires Apache Ivy.
> + #:python ,python-2 ; Needed when overriding inherited args.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-source
> + (lambda _ (chdir "lang/py") #t))))))))
Rather:
(package
(inherit base)
(arguments
(substitute-keyword-arguments (package-arguments python-avro)
((#:phases _)
`(modify-phases %standard-phases
(add-after 'unpack 'enter-source …))))))
OK with this change, thanks!
Ludo’.
- Re: [PATCH 1/4] gnu: Add python-avro.,
Ludovic Courtès <=