guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch v2 3/3] gnu: Add pdfposter.


From: Ludovic Courtès
Subject: Re: [Patch v2 3/3] gnu: Add pdfposter.
Date: Thu, 10 Nov 2016 11:48:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Efraim Flashner <address@hidden> skribis:

> On Wed, Nov 09, 2016 at 11:39:13PM +0100, Hartmut Goebel wrote:
>> * gnu/packages/pdf.scm(pdfposter): New variable.
                         ^
Space.  :-)

[...]

>> +    (arguments
>> +     `(#:tests? #f  ; no test suite, only for visula control
>                                                 ^^^^^^^
>                                             typo

[...]

>> +PDF.  Since sometimes @command{poster} does not like your files converted 
>> from
>> +PDF. :-) Indeed @command{pdfposter} was inspired by @command{poster}.")
>         ^^^^
> I would leave this out

I agree with Efraim.

LGTM with these changes.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]