guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch v2 1/3] gnu: Add python-pypdf2.


From: Ludovic Courtès
Subject: Re: [Patch v2 1/3] gnu: Add python-pypdf2.
Date: Thu, 10 Nov 2016 13:35:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hartmut Goebel <address@hidden> skribis:

> Am 10.11.2016 um 11:46 schrieb Ludovic Courtès:
>>> > +    (arguments
>>> > +     `(#:tests? #f)) ; tests fail in Python 3 (due to str vs bytes)
>> So probably we should only build the Python 2 variant?  WDYT?
>>
>
> The main feature of PyPDF2 is that is supports Python 3, what the old
> pyPdf does not. So we need Python 3.
>
> The test suite does not fail in the sense that it shows bugs, but in a
> way that shows the test suite was not adopted to work with Python 3. The
> test-suite is negligible anyway.  I'll update the comment.

Hmm, OK.  That doesn’t make it sounds like it’s really safe to use with
Python 3.

At the very least, the test suite should be disabled only for the
Python 3 variant IMO, and with a slightly more detailed explanation in
the comment.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]