guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34086] [PATCH] Add StepMania


From: Ludovic Courtès
Subject: [bug#34086] [PATCH] Add StepMania
Date: Sun, 20 Jan 2019 19:09:26 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Nicolas,

Nicolas Goaziou <address@hidden> skribis:

> Note that I had to remove all bundled songs due to a non-commercial
> clause, so it's not really usable right out of the box. I also had to
> package a dedicated FFmpeg package, since StepMania is very picky about
> it.

Apparently you also tried using ffmpeg 2.8, but that didn’t work either?
Do you have an idea how different their own ffmpeg variant is?

>>From bfefd4b4217d67f9628682cb76ce2b9015285612 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <address@hidden>
> Date: Sun, 11 Nov 2018 00:43:34 +0100
> Subject: [PATCH] gnu: Add stepmania.
>
> * gnu/packages/games.scm (ffmpeg-for-stepmania):
> (stepmania): New variables.

[...]

> +(define ffmpeg-for-stepmania
> +  (package
> +    (name "ffmpeg-for-stepmania")

Could you move to video.scm, inherit from ‘ffmpeg’, and arrange to
reduce duplication as much as possible?

(Even better would be to avoid it altogether but I’m assuming it won’t
be that simple…)

The rest LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]