Re: [patch #6448] [MSVC 7/7] Add MSVC Support

[Ralf Wildenhues]

* Peter Rosin wrote on Fri, Aug 15, 2008 at 11:36:14AM CEST:
> Ralf Wildenhues skrev:
>>
>> Please add "Set to @code{false} on systems that cannot create
>> reloadable objects" to the reload_cmds documentation in libtool.texi.
>
> I used @samp(false) instead, as that seemed to be the usage for
> constants in the surrounding entries.

Fine with me.

>>> --- a/libltdl/m4/libtool.m4
>>> +++ b/libltdl/m4/libtool.m4
>>> @@ -4821,6 +4821,7 @@ _LT_EOF
>>>         mt -manifest "@address@hidden" -outputresource:"@address@hidden";
>>>         $RM "@address@hidden";
>>>       fi'
>>> +   reload_cmds=false
>>
>> Why is this not set in _LT_CMD_RELOAD?  That's where reload_cmds is set
>> (exceptions not invalidating the rule ;-)
>
> Because - explanation retrofitted :-) - I only want to set it to false
> for cc_basename matching cl*, and cc_basename isn't available in
> _LT_CMD_RELOAD. So I added a call to _LT_CC_BASENAME to _LT_CMD_RELOAD,
> is that ok.

No, sorry, that is not ok.  We don't want _LT_CC_BASENAME to be expanded
more than once, and we don't want reload_cmds to depend on $CC at all if
we can avoid it.

I see two ways out: either go with your first patch, or not depend on
$cc_basename here.  This is after all mostly a linker-only business.
Can we depend on $LD to decide?

Thanks,
Ralf

> 2008-08-15  Peter Rosin  <address@hidden>
>
>       * libltdl/m4/libtool.m4 (_LT_CMD_RELOAD)
>       [cygwin, mingw, pw32, cegcc] <cl*>: Indicate that reloadable
>       objects does not work.
>       * tests/duplicate_conv.at: Skip last test if reloadable
>       objects does not work.
>       * doc/libtool.texi (libtool script contents): Document how to
>       indicate that reloadable objects does not work.

> --- a/libltdl/m4/libtool.m4
> +++ b/libltdl/m4/libtool.m4
> @@ -3023,7 +3023,15 @@ case $reload_flag in
>  *) reload_flag=" $reload_flag" ;;
>  esac
>  reload_cmds='$LD$reload_flag -o $output$reload_objs'
> +_LT_CC_BASENAME([$CC])
>  case $host_os in
> +  cygwin* | mingw* | pw32* | cegcc*)
> +    if test "$GCC" != yes; then
> +      case $cc_basename in
> +      cl*) reload_cmds=false ;;
> +      esac
> +    fi
> +    ;;