[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: import variables for MSVC.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] tests: import variables for MSVC. |
Date: |
Fri, 24 Sep 2010 07:21:20 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Peter,
* Peter Rosin wrote on Fri, Sep 24, 2010 at 12:25:14AM CEST:
> Subject: [PATCH] tests: import variables for MSVC.
>
> * tests/depdemo/sysdep.h (EXTERN): New define, saying how to
> declare variables that might need to be imported.
> * tests/depdemo/l1/l1.h, tests/depdemo/l2/l2.h,
> tests/depdemo/l3/l3.h, tests/depdemo/l4/l4.h: Use it.
> * tests/demo/foo.h (EXTERN): New define, saying how to declare
> variables that might need to be imported. Use it.
> * tests/pdemo/foo.h (EXTERN) [MSVC]: Make MSVC import variables
> if needed.
Patch is ok with me if it keeps GCC working, and Chuck is ok with it.
You meant to use __declspec everywhere not declspec, even in your text
part of the mail, right?
A documentation addition describing the most general case of annotations
(multiple libraries, mixed static/shared, full MSVC + everything else
support) plus simplifications for common cases,
- no MSVC,
- no shared/static mixing,
- rely on auto-import,
- ...
would be good to have. Something from which I can deduce that your
patch must be correct.
Of course, if libtool can somehow help with this any more, so much the
better. But I'm less optimistic on this than I was those five years
ago. :-/
Also, may I remind you that you promised a number of testsuite additions
before the release.
Thanks,
Ralf
- [PATCH] tests: import variables for MSVC., Peter Rosin, 2010/09/23
- Re: [PATCH] tests: import variables for MSVC., Vincent Torri, 2010/09/23
- Re: [PATCH] tests: import variables for MSVC.,
Ralf Wildenhues <=
- Re: [PATCH] tests: import variables for MSVC., Peter Rosin, 2010/09/24
- Re: [PATCH] tests: import variables for MSVC., Charles Wilson, 2010/09/24
- Re: [PATCH] tests: import variables for MSVC., Ralf Wildenhues, 2010/09/24
- Re: [PATCH] tests: import variables for MSVC., Roumen Petrov, 2010/09/24
- Re: [PATCH] tests: import variables for MSVC., Roumen Petrov, 2010/09/24
- Re: [PATCH] tests: import variables for MSVC., Charles Wilson, 2010/09/25
- Re: [PATCH] tests: import variables for MSVC., Charles Wilson, 2010/09/25
- Re: [PATCH] tests: import variables for MSVC., Roumen Petrov, 2010/09/25
Re: [PATCH] tests: import variables for MSVC., Charles Wilson, 2010/09/24