Re: [patch] allow --with-pic to accept package names

[Ralf Wildenhues]

Hi Ollie,

* Ollie Wild wrote on Mon, Nov 08, 2010 at 05:09:44AM CET:
> On Sat, Oct 23, 2010 at 2:32 AM, Ralf Wildenhues wrote:
> >
> > This patch looks ok but it uses $pkg and $p which are not in Libtool's
> > name space, and it lacks updates to NEWS, libtool.texi, and the test
> > suite.  Oh yes, the --enable-shared code has similar problems, but a
> > patch shouldn't be held hostage for drive-by bugs.  ;-)
> 
> Here's an updated patch which includes a new test, documentation, and
> fixed variable names.  Please take another look.

> 2010-11-07  Ollie Wild  <address@hidden>
> 
>       Modify --with-pic to support per-package configurations.
>       * libltdl/m4/libtool.m4:  Modify --with-pic to accept a list of
>       package names.  Modelled off --enable-shared.
>       * tests/with-pic.at: New test.
>       * Makefile.am (TESTSUITE_AT): Add tests/with-pic.at.
>       * doc/libtool.texi (LT_INIT): Enhance documentation of
>       --with-pic configure flag.
>       * NEWS (New features): Mention that --with-pic now accepts a
>       comma-separated list of package names.

Thanks.  The patch looks good to me, with only trivial nits:
the testsuite addition should be sorted under the 'libtool script
generation' banner rather than with the sysroot tests, and I don't
think that it is necessary to skip the test if static libraries are
disabled: your --disable-shared will (should!) lead to static libs
being enabled everywhere.

I'm pushing the patch with the diff below squashed in, hope you
don't mind.

Cheers,
Ralf

diff --git a/Makefile.am b/Makefile.am
index 53c8e8b..66f38b1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -502,6 +502,7 @@ TESTSUITE_AT        = tests/testsuite.at \
                  tests/ctor.at \
                  tests/exceptions.at \
                  tests/early-libtool.at \
+                 tests/with-pic.at \
                  tests/no-executables.at \
                  tests/deplibs-ident.at \
                  tests/configure-iface.at \
@@ -511,8 +512,7 @@ TESTSUITE_AT        = tests/testsuite.at \
                  tests/darwin.at \
                  tests/dumpbin-symbols.at \
                  tests/deplibs-mingw.at \
-                 tests/sysroot.at \
-                 tests/with-pic.at
+                 tests/sysroot.at
 
 EXTRA_DIST     += $(srcdir)/$(TESTSUITE) $(TESTSUITE_AT) 
$(srcdir)/tests/package.m4
 
diff --git a/tests/with-pic.at b/tests/with-pic.at
index a80535b..c01e5d7 100644
--- a/tests/with-pic.at
+++ b/tests/with-pic.at
@@ -26,8 +26,6 @@ eval `$LIBTOOL --config | $EGREP '^(pic_flag|FGREP)='`
 
 AT_CHECK([test "z$pic_flag" != "z" || exit 77])
 AT_CHECK([test "$at_srcdir" != . || exit 77])
-AT_CHECK([$LIBTOOL --features | $FGREP 'enable static libraries' || exit 77],
-        [], [ignore], [ignore])
 
 CONFIGURE=$abs_top_srcdir/tests/demo/configure
 : ${MAKE=make}