[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] allow --with-pic to accept package names

From: Ollie Wild
Subject: Re: [patch] allow --with-pic to accept package names
Date: Wed, 10 Nov 2010 18:11:45 -0600

On Wed, Nov 10, 2010 at 3:41 PM, Ralf Wildenhues <address@hidden> wrote:
> Thanks.  The patch looks good to me, with only trivial nits:
> the testsuite addition should be sorted under the 'libtool script
> generation' banner rather than with the sysroot tests, and I don't
> think that it is necessary to skip the test if static libraries are
> disabled: your --disable-shared will (should!) lead to static libs
> being enabled everywhere.
> I'm pushing the patch with the diff below squashed in, hope you
> don't mind.

Sounds good to me.  Thanks, Ralf.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]