[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.
From: |
Peter Rosin |
Subject: |
Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used. |
Date: |
Wed, 19 Sep 2012 21:55:32 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 |
On 2012-09-19 21:43, Roumen Petrov wrote:
> Peter Rosin wrote:
>> * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic
>> "flag", but never applies it to static libraries. Cater for this
>> and skip if no "real" pic flag is in use.
> I'm not sure that this test is suitable for mingw host.
>
>
>> Signed-off-by: Peter Rosin <address@hidden>
>> ---
>> tests/with-pic.at | 11 ++++++++++-
>> 1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> Ok to push?
> No as libtool should define -DPIC and for mingw host "pic" flag is
> -DDLL_EXPORT
The test skips on MinGW with the patch, w/o the patch it
fails. You are first saying that the test is not suitable
for MinGW (implying that a skip is in order), and then you
don't like the patch (implying that a fail is good news).
You don't make any sense.
So, what do you mean?
Cheers,
Peter