[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

From: Peter Rosin
Subject: Re: [PATCH] tests: feed -no-undefined when linking libtool libraries
Date: Wed, 19 Sep 2012 22:18:14 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1

On 2012-09-19 21:32, Roumen Petrov wrote:
> Peter Rosin wrote:
>> On 2012-09-19 09:31, Peter Rosin wrote:
>>> * tests/ Make sure shared libraries are created
>>> on Windows by passing -no-undefined. Otherwise fails to record
>>> a dependency on, and the final link of the program then fails
>>> with undefined symbols.
>>> Signed-off-by: Peter Rosin <address@hidden>
>>> ---
>>>   tests/ |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>> Ok to push?
> No idea . Test pass to me with current repository code, cross build , run in 
> emulated .

You haven't finished reading the thread. The problem was
deeper and the regression has been identified as an
accidentally inverted test. Adding -no-undefined was not
the correct answer (I hinted at that suspicion in my
original message), but if your setup works with git
master, then your setup does not behave as the real
MinGW behaves when trying to link with undefined symbols.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]