lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves gro


From: lilypond
Subject: Re: [Lilypond-auto] Issue 3330 in lilypond: bracketify-stencil moves grob's refpoint
Date: Sat, 18 May 2013 19:00:00 +0000


Comment #62 on issue 3330 by address@hidden: bracketify-stencil moves grob's refpoint
http://code.google.com/p/lilypond/issues/detail?id=3330

Ok, here is the current list of differences:
chord-names-languages.png: 48 differences
chord-slash-separator.png: 126 differences
footnote-auto-numbering-page-reset-page1.png: 574 differences
footnote-auto-numbering-page-reset-page2.png: 11329 differences
footnote-auto-numbering-page1.png: 576 differences
footnote-auto-numbering-page2.png: 11406 differences
footnote-auto-numbering-vertical-order-page1.png: 11445 differences
footnote-auto-numbering-vertical-order-page2.png: 1089 differences
footnote-break-visibility-page1.png: 456 differences
footnote-break-visibility-page2.png: 456 differences
footnote-break-visibility-page3.png: 456 differences
footnote-footer-padding.png: 1738 differences
footnote-page1.png: 678 differences
footnote-page2.png: 4276 differences
footnote-spanner-page1.png: 1158 differences
footnote-spanner-page2.png: 18099 differences
fret-diagrams-size.png: 4153 differences
in-note-page1.png: 29518 differences
in-note-page2.png: 26704 differences
instrument-name-markup.png: 120 differences
markup-arrows.png: 246 differences
markup-braces.png: 156 differences
old-regtest-results/markup-cyclic-reference-page1.png does not exist
old-regtest-results/markup-cyclic-reference-page2.png does not exist
markup-lines-page1.png: 692 differences
markup-lines-page2.png: 92 differences
markup-music-glyph.png: 49 differences
markup-note-styles.png: 32405 differences
markup-note.png: 2290 differences
markup-rest.png: 29430 differences
markup-scheme.png: 10110 differences
markup-special-characters.png: 3470 differences
markup-syntax.png: 3834 differences
morgenlied.png: 596 differences
one-line-breaking.png: 152 differences
page-headers-and-footers-page1.png: 21765 differences
page-headers-and-footers-page2.png: 12337 differences
page-headers-and-footers-page3.png: 21914 differences
parenthesize-markup.png: 855 differences
pdfmark-metadata.png: 493 differences
predefined-fretboards.png: 48 differences
profile-property-access.png: 126 differences
test-output-distance.png: 1344 differences
typography-demo.png: 126 differences
42 differences found.

There are still a few differences due to Stencil::add_at_edge changes that either need to disappear or need to get folded into a separately tested patch. Here is a bit of old code:

  Real offset = (my_extent.is_empty () ? 0.0 : my_extent[d] - his_extent)
                + d * padding;

  Stencil toadd (s);
  toadd.translate_axis (offset, a);
  add_stencil (toadd);

This implies (among other things) that if you are adding onto an empty stencil, the result gets the metrics of the added stencil but is shifted by the value of padding. Which does not make a whole lot of sense to me: if you start with an empty stencil, the first addition does not want padding as far as I can see. So I'll probably make a minimal commit first which does not do that, and compare with _that_.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]