|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5220 Let repeatTie work inside of event-chord |
Date: | Sun, 22 Oct 2017 10:53:20 +0000 |
James, many thanks for testing!
Though, again this was not triggered by my local make check.
I don't have the C++-skills to fix it, so I can't continue on this.
I think I'll remove myself as the owner. Should I set it to abandoned?
If the programming error would have shown up with my local checking I wouldn't have uploaded this patch, saving you the work.
Sometimes I think ist's absolutely pointless for me to run the regtests locally ...
That said, some remarks:
Obviously we cared about the possibility to parenthesize RepeatTie, but not for LaissezVibrerTie, so it's not surprising that it bombs out while replacing the repeat-tie-code with renamed laissez-vibrer-code.
Wouldn't it make sense to make parenthesizing LaissezVibrerTie work as well?
[issues:#5220] Let repeatTie work inside of event-chord
Status: Started
Created: Sat Oct 21, 2017 04:11 PM UTC by Thomas Morley
Last Updated: Sun Oct 22, 2017 09:19 AM UTC
Owner: Thomas Morley
Attachments:
Let repeatTie work inside of event-chord
The previous coding of repeat-tie-engraver.cc is replaced by the
renamed coding of the laissez-vibrer-engraver.
http://codereview.appspot.com/335910043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |