lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Move ambitus print callback to scheme


From: Carl Sorensen
Subject: Re: [PATCH] Move ambitus print callback to scheme
Date: Wed, 26 Aug 2009 14:43:34 -0600



On 8/25/09 2:28 PM, "Neil Puttock" <address@hidden> wrote:

> Hi,
> 
> I've just posted a revised patchset which deals with Han-Wen's comments.
> 
> http://codereview.appspot.com/110047/show

The patch looks good to me.

I have a question about style, though.

You code the empty list as (list).  I typically code the empty list as '().

It there a preference?  I suspect that we ought to be consistent, although
it's not highly important.  It could be part of the code janitor work,
though.

Thanks,

Carl





reply via email to

[Prev in Thread] Current Thread [Next in Thread]