[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Clean up `make help' output.

From: Mark Polesky
Subject: Re: [PATCH]: Clean up `make help' output.
Date: Tue, 19 Jan 2010 09:47:02 -0800 (PST)

John Mandereau wrote:
> As for any portability issue, you can't simply remove the
> "-e" just because it works better for you.  Least you
> should do by submitting such a patch is telling us your OS
> and shell name and version; in order to be sure whether to
> apply this patch or not is to investigate which shell
> flavours and versions support or not -e flag, and in which
> cases -e is needed, by reading their respective
> documentations.  FWIW it is supported and needed on my
> system (Fedora 12, bash-4.0.35, coreutils-7.6-8 which
> provides /bin/echo).

Well, that's why I wouldn't push it without asking.  I
tested the patch on my system and the -e is clearly not
needed (everything works fine without it).

Ubuntu 9.10 (x86_64)
GNU bash 4.0.33(1)
coreutils 7.4-2ubuntu1 (with /bin/echo)

> That said, the simplest way to fix this portability issue
> is putting "@echo" at the beginning of each line.

I see.  Okay, here's a new patch that
  * cleans up some more `make help' outputs
  * incorporates multiple lines of "@echo"

I didn't know exactly what to do with these lines in, so I left them alone for now:

249 test:
250         @echo -en 'For tracking crashes: use\n\n\t'
251         @echo 'grep sourcefilename [...]'
252         @echo

- Mark


Attachment: 0001-Clean-up-make-help-output.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]