[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Align metronome mark at time signature or first musical element. Fix
From: |
Han-Wen Nienhuys |
Subject: |
Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041) |
Date: |
Sun, 29 Aug 2010 15:59:30 -0300 |
On Sun, Aug 29, 2010 at 3:54 PM, Jan Nieuwenhuizen
<address@hidden> wrote:
> Op zondag 29-08-2010 om 18:04 uur [tijdzone +0000], schreef
> address@hidden:
>
>> http://codereview.appspot.com/1579041/diff/42001/43004#newcode109
>> lily/metronome-engraver.cc:109: }
>> this is out of style with the rest of lilypond code base.
>>
>> The normal pattern is to use XXx_interface::has_interface (for
>> hard-coded interfaces), or grob->[internal_]has_interface(), to check
>> for softcoded interfaces.
>
> Thanks for catching this. I've applied the patch below.
LGTM
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), jan . nieuwenhuizen, 2010/08/24
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), n . puttock, 2010/08/25
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), n . puttock, 2010/08/26
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), jan . nieuwenhuizen, 2010/08/27
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), hanwenn, 2010/08/29
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), reinhold . kainhofer, 2010/08/29
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), hanwenn, 2010/08/29
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), n . puttock, 2010/08/29
- Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041), n . puttock, 2010/08/29