[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add modal transformations provided by Mike Ellis (issue4079064)
From: |
percival . music . ca |
Subject: |
Re: Add modal transformations provided by Mike Ellis (issue4079064) |
Date: |
Wed, 16 Feb 2011 18:11:05 +0000 |
LGTM
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830
Documentation/notation/pitches.itely:830: left untransformed and a
warning given.}
I'd omit the "and a warning given". I mean, the warning will be
obvious, right? Just end with "... left untransformed."
http://codereview.appspot.com/4079064/diff/7001/input/regression/modal-transforms.ly
File input/regression/modal-transforms.ly (right):
http://codereview.appspot.com/4079064/diff/7001/input/regression/modal-transforms.ly#newcode11
input/regression/modal-transforms.ly:11: motive = {
I'm amused by the discrepancy between "motif" (in the docs) and "motive"
(in this regtest).
http://codereview.appspot.com/4079064/