Re: Fret diagram fixes (issue4176056)

[Carl . D . Sorensen]

On 2011/02/17 16:17:29, nicolas.sceaux wrote:
> Hi,

> Here is a patch for fret diagrams, but as I have very little knowledge
of them I
> may well be wrong on some points.

> First, it fixes sizing issues, when the size property is overridden:
the xo
> signs became too big, and too far from the first fret. It seems that
there was a
> unnecessary "* size".

Looks good to me.  Thanks for checking this out.


> Then, it adds the possibility to use letters for fingers. On the book
I'm
> reading, "P" is used for the thumb ("pouce" in French).

> A new feature is also to invert a dot color, on a per-dot basis. Also
on the
> book I'm referring to, this is used to show where the fundamental note
is on a
> chord.

I like the fact that you've done this, and that you've done it only for
the verbose style diagram.  That way, you haven't added complexity to
the terse diagram.


> Finally, the patch adds a way to customize the first fret label.
> There is also a modification of the first fret label position, but
maybe this is
> a mistake. Is the label supposed to be vertically centered with the
fret line?
> or the bottom of the label should be aligned with the fret line? In
the former
> case, I should cancel the modification.

From every reference I have, it is supposed to be vertically centered
with the fret line.  That was the intent in the original code.

Thanks,

Carl

P.S.  Can you adjust your mime-types entry for .scm files so that
side-by-side diffs in Rietveld work?

http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00583.html


http://codereview.appspot.com/4176056/