[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312

From: Janek Warchoł
Subject: Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)
Date: Wed, 6 Apr 2011 10:36:15 +0200

2011/4/4 Graham Percival <address@hidden>
> Ah.  Well, unfortunately we (as a developer community) do not tend
> to review patches very often.
> Think about it this way: how many times have you reviewed my build
> system patches, or Colin's documentation patches?  The same
> reasons why you don't review those patches apply to people looking
> at your patches.

Perhaps... However seasoned developers can understand my patches while
i (mostly) cannot understand their patches, so i quite cannot review

> I have some plans to improve this, but like all our "social
> problems", I'm waiting until 2.14 is out first.


2011/4/5 <address@hidden>
> The latest patch dies badly when trying to compile
> programming error: ignoring weird minimum distance
> continuing, cross fingers
> ... repeated tons and tons of times...
> Try compiling input/regression/ yourself.

Yes, i see it too.
I tried to fix it by proper implementation of "normal" as the default
flag-style. However, i failed (perhaps because i don't understand
scheme). I attach my attempt - it doesn't work at all and i don't know
May i ask for some help with this?
Did i at least found all files that need changes?

As a last resort, i can drop using "normal" prefix for default flags,
but this would mean less elegant and flexible code.


Attachment: 0001-trying-to-implement-normal-flag-style-as-default.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]