[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: separating flags from noteheads in font (issue4273119)
From: |
lemniskata . bernoullego |
Subject: |
Re: separating flags from noteheads in font (issue4273119) |
Date: |
Sat, 11 Jun 2011 05:08:25 +0000 |
2011/6/11 <address@hidden>:
Looks good, but untested. I'll test it when I can.
Ok. Don't forget to make clean in build/mf - there are still missing
dependencies.
Thanks!
http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4273119/diff/3001/mf/feta-noteheads.mf#newcode45
mf/feta-noteheads.mf:45: numeric black_notehead_width;
On 2011/06/10 23:12:15, Carl wrote:
Perhaps a comment here to indicate that we have deliberately *not*
used a save
statement for black_notehead_width in order to allow it to be a global
variable
available for other .mf files. This will help keep people from saying
"Hey --
good practice says to make local variables; let's make it local"
Done.
http://codereview.appspot.com/4273119/
- Re: separating flags from noteheads in font (issue4273119), lemniskata . bernoullego, 2011/06/10
- Re: separating flags from noteheads in font (issue4273119), Carl . D . Sorensen, 2011/06/10
- Re: separating flags from noteheads in font (issue4273119),
lemniskata . bernoullego <=
- Re: separating flags from noteheads in font (issue4273119), lemzwerg, 2011/06/11
- Re: separating flags from noteheads in font (issue4273119), Janek Warchoł, 2011/06/13
- Re: separating flags from noteheads in font (issue4273119), Janek Warchoł, 2011/06/13
- Re: separating flags from noteheads in font (issue4273119), Marc Hohl, 2011/06/14
- Re: separating flags from noteheads in font (issue4273119), Janek Warchoł, 2011/06/16
- Re: separating flags from noteheads in font (issue4273119), Carl Sorensen, 2011/06/16
- Re: separating flags from noteheads in font (issue4273119), Marc Hohl, 2011/06/17
- Re: separating flags from noteheads in font (issue4273119), Colin Campbell, 2011/06/14
- Re: separating flags from noteheads in font (issue4273119), Carl Sorensen, 2011/06/15
- Re: separating flags from noteheads in font (issue4273119), Janek Warchoł, 2011/06/16