[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Implements multiple-line non-cross-staff glissandi (issue4527086)
From: |
n . puttock |
Subject: |
Re: Implements multiple-line non-cross-staff glissandi (issue4527086) |
Date: |
Sun, 12 Jun 2011 15:49:01 +0000 |
On 2011/06/05 10:18:18, mike_apollinemike.com wrote:
On Jun 2, 2011, at 9:00 PM, mailto:address@hidden wrote:
>
> http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm
> File scm/output-lib.scm (right):
>
>
http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#newcode795
> scm/output-lib.scm:795: (define-public
(glissando::before-line-breaking
> grob)
> Possibly silly question: can't you fold this into callbacks for
> left-bound-info/right-bound-info instead?
Sorry - I don't get what you mean :( Could you please elaborate?
You're calculating a value for 'Y which you add back into bound-details.
This bypasses the default calculation in calc_bound_info (). Why not
caculate 'Y when left-bound-info/right-bound-info is requested, either
directly in C++ or as glissando-specific scheme versions?
http://codereview.appspot.com/4527086/