|
From: | n . puttock |
Subject: | Re: Implements multiple-line non-cross-staff glissandi (issue4527086) |
Date: | Sun, 26 Jun 2011 17:01:36 +0000 |
http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly File input/regression/glissando-broken-multiple.ly (right): http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode7 input/regression/glissando-broken-multiple.ly:7: ragged-right = ##T } ##t } http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode10 input/regression/glissando-broken-multiple.ly:10: \override Glissando #'breakable = ##t you probably also want after-line-breaking = ##t to show the last glissando http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode11 input/regression/glissando-broken-multiple.ly:11: d1 \glissando | d1\glissando http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode15 input/regression/glissando-broken-multiple.ly:15: c,1^\ff\trill is the dynamic relevant? http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode798 scm/output-lib.scm:798: (define-public (glissando::before-line-breaking grob) use assoc-set! to simplify this (i.e., just mutate bound-details instead of rebuilding it) http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode809 scm/output-lib.scm:809: (ly:grob-set-property! grob 'bound-details bd))) (set! (ly:grob-property grob 'bound-details) http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode811 scm/output-lib.scm:811: (define-public (glissando::internal-before-line-breaking grob dir) define inside callback as helper function http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode823 scm/output-lib.scm:823: (extra-dy (assoc-get 'extra-dy details 0.0)) extra-dy isn't a nested property http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode826 scm/output-lib.scm:826: (y (+ (interval-center (ly:grob-extent bound common-y Y)) this overwrites user override for 'Y http://codereview.appspot.com/4527086/diff/17001/scm/output-lib.scm#newcode829 scm/output-lib.scm:829: (cons (cons 'Y y) details))) (acons 'Y y details) http://codereview.appspot.com/4527086/
[Prev in Thread] | Current Thread | [Next in Thread] |