Re: Current state of automatic footnotes. (issue4580041)

[bordage . bertrand]

Hi Mike!
There is a problem with your patch, I can not compile until the end,
even after "git clean -fxd." This crashes when building internals.texi
And there is still the same spacing issues with "number_raise" and notes
higher than 9...

Thanks,
Bertrand


http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc#newcode209
lily/page-layout-problem.cc:209: annotation->translate_axis
(footnote_stencil->extent (Y_AXIS)[UP] + number_raise -
annotation->extent(Y_AXIS)[UP], Y_AXIS);
Looks like the vertical spacing problem comes from here.
Why not just :
annotation->translate_axis (number_raise, Y_AXIS);
?
Or with a Scheme interface that allows users to chose between fixed and
variable height ?
Same comment for line 239.

http://codereview.appspot.com/4580041/