[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: print transposed guitar chords on piano sheets (issue4626094)
From: |
Carl . D . Sorensen |
Subject: |
Re: print transposed guitar chords on piano sheets (issue4626094) |
Date: |
Thu, 07 Jul 2011 02:21:51 +0000 |
Looks nice!
I have a few suggestions.
As far as running things through the formatter goes, the current
formatter in git master is *not* the one that we are trying to get
approved. So it shouldn't be run on current files.
Thanks for your work!
Carl
http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc
File lily/chord-name-engraver.cc (right):
http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc#newcode177
lily/chord-name-engraver.cc:177: SCM capovertical = get_property
("capoVertical");
capovertical should be capo_vertical
http://codereview.appspot.com/4626094/diff/8001/lily/chord-name-engraver.cc#newcode189
lily/chord-name-engraver.cc:189: chord_name_->set_property ("text",
final_markup);
I recommend that all this be done in the form of a scheme procedure, and
that the scheme procedure be called.
That would make it much easier to alter in the future, or for a user to
customize. They can just redefine the Scheme procedure, and they are
good to go.
So you'd have something like
chord_name->set_property ("text", scm_call_3 (chord_name_capo_proc,
markup, capo_markup, capo_vertical))
http://codereview.appspot.com/4626094/
Re: print transposed guitar chords on piano sheets (issue4626094),
Carl . D . Sorensen <=
Re: print transposed guitar chords on piano sheets (issue4626094), n . puttock, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Wols Lists, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Neil Puttock, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Carl Sorensen, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Wols Lists, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Carl Sorensen, 2011/07/07
- Re: print transposed guitar chords on piano sheets (issue4626094), Neil Puttock, 2011/07/10