|
From: | Carl . D . Sorensen |
Subject: | Re: print transposed guitar chords on piano sheets (issue4626094) |
Date: | Sun, 17 Jul 2011 12:45:01 +0000 |
On 2011/07/17 10:35:20, Janek Warchol wrote:
Hi all,
as acting Frog Meister i'm worried that nothing happens here :( Wol, how can i help you? Neil, Carl: do i understand correctly that Wol could've done this using a more elegant solution, but nevertheless his patch doesn't brake anything and works correctly (i don't remember any problems when i tried it)? Can i label it patch-review?
I think it should be patch-needs-work. The proper way to do the capo-chord has been proposed (in Anthony's words -- a "shim"). A sample patch (by Neil) has been referenced. Anthony's patch should be revised to be consistent with Neil's proof-of-concept patch. Thanks, Carl http://codereview.appspot.com/4626094/
[Prev in Thread] | Current Thread | [Next in Thread] |