[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Should this be applied?
From: |
David Kastrup |
Subject: |
Should this be applied? |
Date: |
Mon, 08 Aug 2011 13:43:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
In an attempt to figure out whether my coredumps were related to lying
to the compiler about const, I tried checking the effects of not using
casts to non-const in const member functions. Nothing came off it.
However, there was one not-just-declarational change that seemed like a
sensible thing to do:
diff --git a/lily/item.cc b/lily/item.cc
index 4e98181..14b6751 100644
--- a/lily/item.cc
+++ b/lily/item.cc
@@ -178,7 +178,7 @@ Item::break_visible (Grob *g)
bool
Item::pure_is_visible (int start, int end) const
{
- SCM vis = get_property ("break-visibility");
+ SCM vis = get_pure_property ("break-visibility", start, end);
if (scm_is_vector (vis))
{
int pos = 1;
I have no clue what start and end are, and I have no clue what pure is.
But get_pure_property takes start and end as additional arguments over
get_property, and so does pure_is_visible.
So from a mere text-matching hand-waving likelihood point of view, the
above change seems plausible.
Is there anybody that could shed light on this?
--
David Kastrup
- Should this be applied?,
David Kastrup <=