[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sketch for broken beams with consistent slopes (issue 4961041)
From: |
Mike Solomon |
Subject: |
Re: Sketch for broken beams with consistent slopes (issue 4961041) |
Date: |
Mon, 3 Oct 2011 20:50:18 +0200 |
On Oct 3, 2011, at 6:53 AM, address@hidden wrote:
> i know it's annoying, but could you separate out the cosmetics (adding _
> ) to members from the rest of this change? The cosmetic changes make it
> difficult to see the essence of what you are trying to do.
>
>
> http://codereview.appspot.com/4961041/diff/39001/lily/include/beam-scoring-problem.hh
> File lily/include/beam-scoring-problem.hh (right):
>
> http://codereview.appspot.com/4961041/diff/39001/lily/include/beam-scoring-problem.hh#newcode151
> lily/include/beam-scoring-problem.hh:151: vector<Real> stem_ypositions_;
> organize so it's clear to what members the comment pertains.
>
> http://codereview.appspot.com/4961041/
It's good, as it eliminates the programming error and makes the line-break
slicker (IMHO).
Cheers,
MS
- Re: Sketch for broken beams with consistent slopes (issue 4961041), mtsolo, 2011/10/03
- Re: Sketch for broken beams with consistent slopes (issue 4961041), hanwenn, 2011/10/03
- Re: Sketch for broken beams with consistent slopes (issue 4961041),
Mike Solomon <=
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Mike Solomon, 2011/10/03
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Mike Solomon, 2011/10/04
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Han-Wen Nienhuys, 2011/10/04
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Mike Solomon, 2011/10/04
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Han-Wen Nienhuys, 2011/10/04
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Mike Solomon, 2011/10/05
- Re: Sketch for broken beams with consistent slopes (issue 4961041), Mike Solomon, 2011/10/04
Re: Sketch for broken beams with consistent slopes (issue 4961041), pkx166h, 2011/10/03
Re: Sketch for broken beams with consistent slopes (issue 4961041), pkx166h, 2011/10/05
Re: Sketch for broken beams with consistent slopes (issue 4961041), pkx166h, 2011/10/06