|
From: | address@hidden |
Subject: | Re: Fixes slope errors from incorrect X extents in Beam::print. (issue 5293060) |
Date: | Fri, 28 Oct 2011 11:09:44 +0200 |
On Oct 28, 2011, at 7:30 AM, Keith OHara wrote:
I've fixed the code so that x_span_ (and all variables containing x information) only ever represent one thing: the full x span of the beam. The distinction between normal-stem to normal-stem versus left-extremity to right-extremity no longer exists. This reduces the complexity (and size) of the code without altering the visual result.
This comment is no longer relevant (my patch fixes this issue). I didn't see it before & I'm removing it now.
I discovered this by accident. The real kicker is that this problem did not just plague broken beams - even unbroken ones have an overhang from the center of the extremal stem by half the stem width (usually 0.065 units). This is non-negligible. In beam-quanting-32nd.ly, for example, there were several too-low quantings that the correction of this minuscule overhang fixes.
You don't need a separate commit: one of the benefits of standardizing x extent across functions is that this is automatically fixed. Attached are the results from current master and from my patch: \paper { ragged-right = ##t } { d'8[ c' b e' r r r r r r r r r] } In the patch, the functions individual-slope and peters-prolongation guarantee quanted beams on both ends. The only one that doesn't is strict-prolongation, as it is impossible to have beams strictly link up and quant their broken ends (or rather, the chances are infinitesimally small). I've included this snippet as a regtest.
Good to hear! Lemme know if you have any other comments, and many thanks for those you've given so far. New patch-set up. Cheers, MS |
[Prev in Thread] | Current Thread | [Next in Thread] |