[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)
From: |
address@hidden |
Subject: |
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062) |
Date: |
Sat, 5 Nov 2011 18:04:49 -0700 |
On Nov 5, 2011, at 4:11 PM, address@hidden wrote:
> http://codereview.appspot.com/5323062/diff/29001/lily/pure-from-neighbor-engraver.cc#newcode49
> lily/pure-from-neighbor-engraver.cc:49: SCM pure_relevant_p =
> ly_lily_module_constant ("pure-relevant?");
> Now, this fills 'items_' with things that pass the 'pure-relevant'
> test.
> (Since you say Item as opposed to Grob, do you exclude slurs and such?)
>
Yup.
> http://codereview.appspot.com/5323062/diff/29001/lily/pure-from-neighbor-engraver.cc#newcode60
> lily/pure-from-neighbor-engraver.cc:60: pure_relevants_.push_back
> (i.item ());
> But 'pure_relevants_' is something different from simply things that
> satisfy the predicate 'pure-relevant?'. It looks like it includes only
> items in the immediately-adjacent columns.
>
It includes all columns. Immediately adjacent columns are assigned in
Pure_from_neighbor_interface::keep_next_door_neighbors .
> This would seems to let accidentals on the second-neightbor-column cross
> the extended bar lines. How would this (untested) work?
>
> \new PianoStaff <<
> \new Staff { R1*4 }
> \new Staff {
> e'1 | \acciaccatura e'16 <e'' cis''' dis'''>4 r2. |
> \slurUp \acciaccatura c''16 <c' fis gis>4 r2.
> <c' fis gis>4 r2.
> } >>
You're right - good catch! I've put patch set up that fixes this.
Cheers,
MS
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), (continued)
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), David Kastrup, 2011/11/05
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), Keith OHara, 2011/11/07
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), address@hidden, 2011/11/07
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), Keith OHara, 2011/11/08
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), address@hidden, 2011/11/08
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), address@hidden, 2011/11/08
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), Keith OHara, 2011/11/08
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), David Kastrup, 2011/11/08
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), pkx166h, 2011/11/04
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), k-ohara5a5a, 2011/11/05
- Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062),
address@hidden <=
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), pkx166h, 2011/11/06
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), k-ohara5a5a, 2011/11/06
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), mtsolo, 2011/11/07
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), pkx166h, 2011/11/07
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), pkx166h, 2011/11/08
Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062), k-ohara5a5a, 2011/11/09