[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allows for automatic renumbering of measure numbers at volta repeats
Re: Allows for automatic renumbering of measure numbers at volta repeats. (issue 5440049)
Tue, 29 Nov 2011 03:54:42 +0000
I'm inspired to name some variables in Irish now! And, I'll be sure the
names are misleadingly related, but critically distinct, from the
conceptual contents of the variable.
File lily/bar-number-engraver.cc (right):
lily/bar-number-engraver.cc:38: int renvoi_number_;
Isn't there already a counter for that somewhere?
Nested \alternatives fool it, but I couldn't make it crash so that
should be fine.
lily/bar-number-engraver.cc:64: SCM renvoi_dir_scm = context
I guess you made it a direction for type-checking purposes?
lily/bar-number-engraver.cc:65: SCM renvoi_style = context
File lily/include/timing-translator.hh (right):
lily/include/timing-translator.hh:28: int renvoi_;
File lily/timing-translator.cc (right):
lily/timing-translator.cc:85: bool make_renvoi = context
()->get_property ("renvoiStyle") == ly_symbol2scm
lily/timing-translator.cc:86: || context ()->get_property
("renvoiStyle") == ly_symbol2scm
lily/timing-translator.cc:90: if (renvoi_dir == -1)
Desperately seeking comment.
File scm/define-music-properties.scm (right):
scm/define-music-properties.scm:174: (renvoi-dir ,ly:dir? "The direction
of a volta send-back.")
Seems more like: indicates if an AlternativeStart event is the
First (-1), Middle (0), Last (1)
of group of alternate endings.
File scm/define-music-types.scm (right):
Does it need an iterator? does it contain the alternative or is it
merely an event marking the start?