|
From: | graham |
Subject: | Re: Update lilygit.tcl (Issue 2092) (issue 5504092) |
Date: | Fri, 30 Dec 2011 20:57:02 +0000 |
LGTM apart from one detail http://codereview.appspot.com/5504092/diff/5001/scripts/auxiliar/lily-git.tcl File scripts/auxiliar/lily-git.tcl (right): http://codereview.appspot.com/5504092/diff/5001/scripts/auxiliar/lily-git.tcl#newcode295 scripts/auxiliar/lily-git.tcl:295: git push origin HEAD:$pushHead I'm still concerned about this type of automatic pushing. The revised CG material on branches http://codereview.appspot.com/5484043/ makes a bit deal about always checking gitk -- just for 5 seconds -- before pushing, and I think that's a good step. Patchy will not question any ridiculous git history that arises due to any kind of weird series of commands in git. http://codereview.appspot.com/5504092/
[Prev in Thread] | Current Thread | [Next in Thread] |